chore: verify bootstrap version format before merge#36
Merged
Conversation
Relates-to: keymanapp/keyman.com#794 Test-bot: skip
mcdurdin
changed the title
ermshiperete
approved these changes
Jun 16, 2026
| # in the shared-sites repo. We will do this with a heuristic based on the normal | ||
| # shape of the tags, which is `v#.#.#`. Any other shape we will assume is a test | ||
| # branch. | ||
| cat resources/.bootstrap-required-version | grep -qP '^v\d+\.\d+\.\d+$' || ( |
There was a problem hiding this comment.
Also a candidate for a custom GH action - although this is only a few lines it would still reduce code duplication
Member
Author
There was a problem hiding this comment.
Yes, same thing as the other one, keymanapp/keyman.com#795
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates-to: keymanapp/keyman.com#794
Test-bot: skip